Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add animated status icons #2551

Merged
merged 6 commits into from
Aug 2, 2023
Merged

Add animated status icons #2551

merged 6 commits into from
Aug 2, 2023

Conversation

joepavitt
Copy link
Contributor

@joepavitt joepavitt commented Aug 1, 2023

Description

  • Starting: Change the static ... icon from heroicons into an animated three dot flow animation.
  • Installing & Importing: Change the static down arrow to an animated arrow.
  • Restarting: Rotate & pulsate the existing "refresh" icon
Screen.Recording.2023-08-01.at.11.37.13.mov
Screen.Recording.2023-08-01.at.11.59.43.mov
Screen.Recording.2023-08-01.at.12.18.35.mov

Related Issue(s)

#2487

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
    • visual changes only

@joepavitt joepavitt requested a review from Pezmc August 1, 2023 10:39
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #2551 (6ffd455) into main (929a774) will decrease coverage by 73.06%.
Report is 3 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #2551       +/-   ##
==========================================
- Coverage   74.63%   1.58%   -73.06%     
==========================================
  Files         228     498      +270     
  Lines        9164   17794     +8630     
  Branches     1891    4152     +2261     
==========================================
- Hits         6840     282     -6558     
- Misses       2324   17512    +15188     
Flag Coverage Δ
backend ?
frontend 1.58% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
frontend/src/components/StatusBadge.vue 0.00% <ø> (ø)
...ntend/src/components/icons-animated/Installing.vue 0.00% <0.00%> (ø)
...ntend/src/components/icons-animated/Restarting.vue 0.00% <0.00%> (ø)
...rontend/src/components/icons-animated/Starting.vue 0.00% <0.00%> (ø)

... and 443 files with indirect coverage changes

@joepavitt joepavitt marked this pull request as draft August 1, 2023 11:02
@joepavitt joepavitt changed the title Add animated "starting" pill instead of static icon Add animated status icons Aug 1, 2023
@joepavitt
Copy link
Contributor Author

@Pezmc just switched this to draft as going to add some basic anims in for a bunch of states, they're all small wins.

@joepavitt
Copy link
Contributor Author

joepavitt commented Aug 1, 2023

Awaiting confirmation from @hardillb on what "loading" state represents before moving this into "ready for review"

"loading" state doesn't appear to be used, but keeping it in client side just in case we're missing it somewhere.

@joepavitt joepavitt marked this pull request as ready for review August 1, 2023 13:15
Copy link
Contributor

@hardillb hardillb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, looks good. Lets get this on Staging for a proper look

@hardillb hardillb merged commit 530e647 into main Aug 2, 2023
2 of 3 checks passed
@hardillb hardillb deleted the 2487-status-anim branch August 2, 2023 08:55
@hardillb
Copy link
Contributor

hardillb commented Aug 2, 2023

Verified on Staging

@MarianRaphael MarianRaphael linked an issue Aug 2, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve feedback in "Starting" phase
2 participants