Auto-create Application/Instance when first joining FlowForge #2553
Conversation
| @@ -11,6 +11,27 @@ const inflightProjectState = { } | |||
|
|
|||
| const inflightDeploys = new Set() | |||
|
|
|||
| class ControllerError extends Error { | |||
There was a problem hiding this comment.
The long term intension would be to have a standard set of FlowForge error objects that we use throughout the app at various logical levels.
Codecov Report
@@ Coverage Diff @@
## main #2553 +/- ##
==========================================
+ Coverage 39.95% 40.06% +0.10%
==========================================
Files 495 498 +3
Lines 17763 17865 +102
Branches 4145 4182 +37
==========================================
+ Hits 7098 7158 +60
- Misses 10665 10707 +42
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This method doesn't appear to be being used, and the includes clauses were totally invalid; a team doesn't have a projectype, stack or template.
Pezmc
force-pushed
the
feat-2475-auto-create-instance
branch
from
a11f5af
to
e92f982
Compare
|
There is a frustrating out of memory error holding up the tests, but otherwise this is ready for review, pinging @joepavitt for frontend and @hardillb for backend as they have context. |
`app.db.models.Project.byUser(user)` seems to hand during tests, unclear why at this stage.
Pezmc
force-pushed
the
feat-2475-auto-create-instance
branch
from
f185d66
to
b1a1948
Compare
|
Did try to create a new user, but hit errors in doing so. The Node-RED instance logs oddly have recordings from a few days ago?! I have also seen this issue with my other instances too, so fairly sure this is a local problem on my side. 
|
|
Rebuilt FF, clean DB, etc. and it did create an Instance for me when signing up, however, when going to open it: 
|
|
I also still seem to be getting logs from a different instance of Node-RED? 
|
|
Recommend "Default Application" being something like "Firstname Surname's Application" |
|
Final thought, can we know client-side if this is their first time logging in? Cookie/session storage flag/check or something maybe? Would be good to use |
|
@joepavitt Let's investigate that as a follow up, I'm hesitant to keep increasing scope so close to release! |
|
For the record, I looked into how to how to track if this is the users first time landing on the page, but without implementing some sort of server side first time user experience tracking (.e.g a list of alerts the user has seen) or tracking an accounts state (again server side), there was no easy way to add it! |
Description
Adds a new admin config option
user:team:auto-create:instanceTypeto the admins setting screen, nested under auto-creation of team types.If this option is set, when a user verifies their email, if they have a team (which they should always do thanks to the
team:auto-createsetting); the user is also given an application namedDefault Applicationand an instance, which is based on the team, and username, with a random hash, like so:team-name-username-3425aed6Screen.Recording.2023-08-02.at.12.14.34.mov
Related Issue(s)
Fixes #2475
Checklist
flowforge.yml?flowforge/helmto update ConfigMap Templateflowforge/CloudProjectto update values for Staging/ProductionLabels
backportlabelarea:migrationlabel