-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add application description to header of application summary box #2596
Conversation
@MarianRaphael - backport flag required for Thursday release? |
@joe added for frontend code check |
Codecov Report
@@ Coverage Diff @@
## main #2596 +/- ##
==========================================
- Coverage 39.79% 39.77% -0.02%
==========================================
Files 526 527 +1
Lines 18341 18365 +24
Branches 4304 4312 +8
==========================================
+ Hits 7298 7305 +7
- Misses 11043 11060 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Fixed UI tests by adding missed functionality (inputting / displaying application description on application / instance creation) in 4b14b58 |
@joepavitt @knolleary gentle nudge :) Marian has added backport label signifying this will be in Thursday release - needs to be tested on staging etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved from front-end
Add application description to header of application summary box (backport #2596)
Description
Add description to applications. Ensure text does not overflow when sized. Permit user setting of description.
Demo
app-desc.mp4
Commits:
db migration - description column to Applications
update db Application model - add description col
update db view for new column
update backend api for new description field
add description to client API for updating appl'n
front end CRUD for new description field
update unit tests for new description field
update frontend tests for description co
Additional
Docs were reviewed and no immediate changes were necessary BUT there was outdated info present in the Application Concepts. As these were (tenuously) related, I have updated them as part of this PR.
+ 1 typo fixed.
Related Issue(s)
#2279
Checklist
flowforge.yml
?flowforge/helm
to update ConfigMap Templateflowforge/CloudProject
to update values for Staging/ProductionLabels
backport
labelarea:migration
label