Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add application description to header of application summary box #2596

Merged
merged 12 commits into from
Aug 16, 2023

Conversation

Steve-Mcl
Copy link
Contributor

Description

Add description to applications. Ensure text does not overflow when sized. Permit user setting of description.

Demo

app-desc.mp4

Commits:

db migration - description column to Applications

update db Application model - add description col

update db view for new column

update backend api for new description field

add description to client API for updating appl'n

front end CRUD for new description field

update unit tests for new description field

update frontend tests for description co

Additional

Docs were reviewed and no immediate changes were necessary BUT there was outdated info present in the Application Concepts. As these were (tenuously) related, I have updated them as part of this PR.
+ 1 typo fixed.

Related Issue(s)

#2279

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl added the area:migration Involves a database migration label Aug 15, 2023
@Steve-Mcl Steve-Mcl linked an issue Aug 15, 2023 that may be closed by this pull request
@Steve-Mcl
Copy link
Contributor Author

@MarianRaphael - backport flag required for Thursday release?

@Steve-Mcl
Copy link
Contributor Author

@joe added for frontend code check
@knolleary for backend db/api work.

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #2596 (ca01b95) into main (14a2223) will decrease coverage by 0.02%.
Report is 6 commits behind head on main.
The diff coverage is 26.47%.

@@            Coverage Diff             @@
##             main    #2596      +/-   ##
==========================================
- Coverage   39.79%   39.77%   -0.02%     
==========================================
  Files         526      527       +1     
  Lines       18341    18365      +24     
  Branches     4304     4312       +8     
==========================================
+ Hits         7298     7305       +7     
- Misses      11043    11060      +17     
Flag Coverage Δ
backend 74.65% <57.14%> (-0.03%) ⬇️
frontend 2.22% <2.94%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ons/20230814-01-add-description-to-applications.js 0.00% <0.00%> (ø)
forge/db/models/Application.js 100.00% <ø> (ø)
forge/db/views/Application.js 89.28% <ø> (ø)
frontend/src/pages/application/Settings.vue 0.00% <0.00%> (ø)
...end/src/pages/instance/components/InstanceForm.vue 0.00% <0.00%> (ø)
frontend/src/pages/team/Applications.vue 0.00% <0.00%> (ø)
frontend/src/pages/team/createApplication.vue 0.00% <0.00%> (ø)
frontend/src/pages/team/createInstance.vue 0.00% <0.00%> (ø)
frontend/src/api/application.js 39.68% <50.00%> (ø)
forge/routes/api/application.js 80.23% <88.88%> (+1.75%) ⬆️

@Steve-Mcl
Copy link
Contributor Author

Fixed UI tests by adding missed functionality (inputting / displaying application description on application / instance creation) in 4b14b58

@Steve-Mcl
Copy link
Contributor Author

@joepavitt @knolleary gentle nudge :)

Marian has added backport label signifying this will be in Thursday release - needs to be tested on staging etc.

Copy link
Contributor

@joepavitt joepavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from front-end

@knolleary knolleary merged commit 009a6b6 into main Aug 16, 2023
5 of 6 checks passed
@knolleary knolleary deleted the 2279-app-description branch August 16, 2023 12:01
knolleary added a commit that referenced this pull request Aug 17, 2023
Add application description to header of application summary box (backport #2596)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:migration Involves a database migration backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to add app description and display in web portal
4 participants