Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix team delete for unmanaged-billing team #3181

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

knolleary
Copy link
Member

Description

The current delete team path attempts to cancel the stripe subscription without taking into account whether the team's billing is unmanaged. This fixes that.

Along the way, a small fix in the stub driver that blocked deleting 'suspended' instances in local testing.

@knolleary knolleary requested review from Pezmc and hardillb and removed request for Pezmc December 7, 2023 11:15
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c7b9f95) 40.20% compared to head (257a980) 40.20%.

Files Patch % Lines
forge/ee/lib/billing/index.js 25.00% 3 Missing ⚠️
forge/routes/api/team.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3181   +/-   ##
=======================================
  Coverage   40.20%   40.20%           
=======================================
  Files         582      582           
  Lines       21353    21352    -1     
  Branches     5137     5137           
=======================================
  Hits         8584     8584           
+ Misses      12769    12768    -1     
Flag Coverage Δ
backend 76.22% <20.00%> (ø)
frontend 1.97% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hardillb hardillb merged commit a9b1fee into main Dec 7, 2023
7 checks passed
@hardillb hardillb deleted the fix-unmanaged-team-delete branch December 7, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants