Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device group audit loggers #3236

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

Steve-Mcl
Copy link
Contributor

Description

Adds 4 new audit log events to the application audit log

  • application.deviceGroup.created
  • application.deviceGroup.updated
  • application.deviceGroup.deleted
  • application.deviceGroup.members.changed

image

Related Issue(s)

#2997

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl linked an issue Dec 19, 2023 that may be closed by this pull request
@Steve-Mcl
Copy link
Contributor Author

Steve-Mcl commented Dec 19, 2023

Note for reviewer:

The Devices membership changed entry info only states "Added x" and "Removed y" since listing out the name of every device added or removed to the log would (in cases of larger users) present a pretty poor view in the audit log.

Happy to be advised otherwise.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (c29af2d) 40.66% compared to head (8af208d) 40.76%.

Files Patch % Lines
...end/src/components/audit-log/AuditEntryVerbose.vue 0.00% 8 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##           2997-device-groups-backend    #3236      +/-   ##
==============================================================
+ Coverage                       40.66%   40.76%   +0.10%     
==============================================================
  Files                             603      603              
  Lines                           22464    22515      +51     
  Branches                         5425     5441      +16     
==============================================================
+ Hits                             9135     9179      +44     
- Misses                          13329    13336       +7     
Flag Coverage Δ
backend 77.54% <100.00%> (+0.09%) ⬆️
frontend 2.02% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from 2997-device-group-frontend to 2997-device-groups-backend December 20, 2023 12:43
@Steve-Mcl
Copy link
Contributor Author

@Pezmc conflict resolved in 8af208d

Please cast a final eye and merge if/when tests pass and you are happy.

@Pezmc Pezmc merged commit 4796eca into 2997-device-groups-backend Dec 20, 2023
10 checks passed
@Pezmc Pezmc deleted the 2997-device-group-auditloggers branch December 20, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementing Device Groups Management
2 participants