Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing audit logger for pipeline stage deploy #3239

Conversation

Steve-Mcl
Copy link
Contributor

@Steve-Mcl Steve-Mcl commented Dec 20, 2023

Description

  • Adds audit log entry application.pipeline.stage-deployed
  • Adds UI for this element
  • Adds tests for all missing team-application-* loggers

Example:

image

Related Issue(s)

#2989

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl
Copy link
Contributor Author

The application.pipeline.stage-deployed was deliberately added alongside other pipeline log entries as opposed to adding it in the Application Audit log.

For clarification: Pipelines were added before Application Audit log - this is already noted as a task in #2820

@Steve-Mcl Steve-Mcl linked an issue Dec 20, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (bef6d99) 40.70% compared to head (0a1110a) 40.71%.
Report is 7 commits behind head on 2989-assign-device-group-to-pipeline-stage.

Files Patch % Lines
...end/src/components/audit-log/AuditEntryVerbose.vue 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                             Coverage Diff                             @@
##           2989-assign-device-group-to-pipeline-stage    #3239   +/-   ##
===========================================================================
  Coverage                                       40.70%   40.71%           
===========================================================================
  Files                                             598      598           
  Lines                                           22311    22342   +31     
  Branches                                         5374     5387   +13     
===========================================================================
+ Hits                                             9082     9096   +14     
- Misses                                          13229    13246   +17     
Flag Coverage Δ
backend 77.38% <100.00%> (+0.02%) ⬆️
frontend 2.03% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pezmc Pezmc merged commit ef99669 into 2989-assign-device-group-to-pipeline-stage Dec 20, 2023
7 checks passed
@Pezmc Pezmc deleted the 2989-add-missing-audit-logger-for-pipeline-stage-deploy branch December 20, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibility to assign Devices Groups to a DevOps Pipeline
2 participants