Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update description of Disable Editor #3245

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

hardillb
Copy link
Contributor

Description

Disable Editor description talks about Admin API access which is not possible as you can't generate a token, but should mention pipelines.

Related Issue(s)

Raised after a forum post
https://community.flowfuse.com/t/enable-disable-flowfuse-instance-device-editor/472

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb added this to the 1.15 milestone Dec 20, 2023
@hardillb hardillb self-assigned this Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 88 lines in your changes are missing coverage. Please review.

Comparison is base (4bf5452) 40.36% compared to head (1b80cea) 40.36%.
Report is 44 commits behind head on main.

Files Patch % Lines
frontend/src/pages/instance/Settings/Alerts.vue 0.00% 44 Missing ⚠️
...ntend/src/pages/admin/Template/sections/Alerts.vue 0.00% 31 Missing ⚠️
frontend/src/pages/admin/Template/index.vue 0.00% 5 Missing ⚠️
...ges/admin/TeamTypes/dialogs/TeamTypeEditDialog.vue 0.00% 4 Missing ⚠️
frontend/src/pages/instance/Settings/index.vue 0.00% 2 Missing ⚠️
forge/ee/lib/alerts/index.js 97.05% 1 Missing ⚠️
...end/src/components/audit-log/AuditEntryVerbose.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3245      +/-   ##
==========================================
- Coverage   40.36%   40.36%   -0.01%     
==========================================
  Files         592      592              
  Lines       21666    21667       +1     
  Branches     5214     5214              
==========================================
  Hits         8746     8746              
- Misses      12920    12921       +1     
Flag Coverage Δ
backend 76.91% <97.50%> (ø)
frontend 1.94% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hardillb hardillb merged commit cf07c7a into main Dec 20, 2023
6 of 7 checks passed
@hardillb hardillb deleted the disable-editor-description branch December 20, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants