Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better defaults for Audit Log view #3269

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Conversation

Steve-Mcl
Copy link
Contributor

@Steve-Mcl Steve-Mcl commented Dec 22, 2023

closes #3125

Description

Improve the situation where audit log entries do not have a matching icon or string.

NOTE: This is not meant to be a substitute for making the necessary updates when adding new audit log entries BUT it will be a catch all and will handle cases out of our control (like new or unhandled Node-RED events)
As discussed in the task:

Forgetting for the moment, all new audit entries should have the UI when they are submitted, do we want to consider presenting new Audit entries a little friendlier?

More background: #2302 (comment)

Platform Log

Before

image

After

image

Team Log

Before

image

After

image

Application Log

Before

image

After

image

Instance/Project Log

Before

image

After

image

Related Issue(s)

#3125

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (9fa974f) 40.74% compared to head (db92975) 40.71%.

Files Patch % Lines
...end/src/components/audit-log/AuditEntryVerbose.vue 0.00% 11 Missing ⚠️
...ontend/src/components/audit-log/AuditEntryIcon.vue 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3269      +/-   ##
==========================================
- Coverage   40.74%   40.71%   -0.04%     
==========================================
  Files         603      603              
  Lines       22527    22544      +17     
  Branches     5445     5450       +5     
==========================================
  Hits         9179     9179              
- Misses      13348    13365      +17     
Flag Coverage Δ
backend 77.54% <ø> (ø)
frontend 2.01% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@joepavitt joepavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it - Great stuff Steve

@joepavitt joepavitt merged commit 0335c90 into main Dec 22, 2023
6 of 7 checks passed
@joepavitt joepavitt deleted the 3125-default-audit-log-icons branch December 22, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better default appearance for audit logs without the matching UI elements
2 participants