Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blueprint Admin: Fix form validation #3270

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Dec 22, 2023

  • Allow submitting form with errors
  • Clear errors on form submit

Description

Related Issue(s)

Fixes #3266

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@Pezmc Pezmc requested a review from knolleary December 22, 2023 12:59
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (9fa974f) 40.74% compared to head (40d02b0) 40.74%.
Report is 2 commits behind head on main.

Files Patch % Lines
...FlowBlueprints/dialogs/FlowBlueprintFormDialog.vue 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3270      +/-   ##
==========================================
- Coverage   40.74%   40.74%   -0.01%     
==========================================
  Files         603      603              
  Lines       22527    22529       +2     
  Branches     5445     5445              
==========================================
  Hits         9179     9179              
- Misses      13348    13350       +2     
Flag Coverage Δ
backend 77.54% <ø> (ø)
frontend 2.01% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary knolleary merged commit 14fbc5f into main Dec 22, 2023
6 of 7 checks passed
@knolleary knolleary deleted the fix-3266-blueprint-validation branch December 22, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin blueprint edit dialog does not clear JSON error message
2 participants