Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GA tracking on create account #3568

Merged
merged 1 commit into from Mar 13, 2024
Merged

Fix GA tracking on create account #3568

merged 1 commit into from Mar 13, 2024

Conversation

knolleary
Copy link
Member

Noticed whilst debugging HS form tracking the recently added GA tracking was causing an error to be thrown if GA wasn't enabled.

The gtag function needed to be explicitly added to window so that it would be visible to code inside vue.

@knolleary knolleary requested a review from hardillb March 13, 2024 14:36
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 41.93%. Comparing base (ac9b70b) to head (f044727).

Files Patch % Lines
frontend/src/pages/account/Create.vue 0.00% 3 Missing ⚠️
forge/routes/ui/index.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3568   +/-   ##
=======================================
  Coverage   41.93%   41.93%           
=======================================
  Files         623      623           
  Lines       23996    23996           
  Branches     5847     5847           
=======================================
  Hits        10062    10062           
  Misses      13934    13934           
Flag Coverage Δ
backend 78.35% <0.00%> (ø)
frontend 1.94% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hardillb hardillb merged commit 1b6e344 into main Mar 13, 2024
7 checks passed
@hardillb hardillb deleted the fix-ga branch March 13, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants