Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter instance editor links pointing to the immersive editor to point to the default editor #3791

Merged

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Apr 29, 2024

Description

Force instance editor links to point to the standard node-red editor instead of the immersive version until we can configure node-red instances to include CSP headers

Related Issue(s)

closes #3786

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@cstns cstns changed the title Disable instance editor links pointing to the immersive editor Alter instance editor links pointing to the immersive editor to point to the default editor Apr 29, 2024
@cstns cstns requested a review from knolleary April 29, 2024 14:41
@cstns cstns self-assigned this Apr 29, 2024
@cstns cstns added the area:frontend For any issues that require work in the frontend/UI label Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 41.76%. Comparing base (64cd01e) to head (b411a5d).

Files Patch % Lines
...ntend/src/pages/instance/components/EditorLink.vue 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3791      +/-   ##
==========================================
- Coverage   41.77%   41.76%   -0.01%     
==========================================
  Files         647      647              
  Lines       24766    24768       +2     
  Branches     6075     6076       +1     
==========================================
  Hits        10345    10345              
- Misses      14421    14423       +2     
Flag Coverage Δ
backend 79.14% <ø> (ø)
frontend 1.88% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary
Copy link
Member

Merging so we aren't blocked making progress elsewhere until the Node-RED header issue is resolved.

@knolleary knolleary merged commit 8c36a97 into main Apr 29, 2024
10 of 11 checks passed
@knolleary knolleary deleted the 3786-immersive-editor-refuses-to-connect-in-production branch April 29, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend For any issues that require work in the frontend/UI deploy:pr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Immersive Editor refuses to connect in production
2 participants