Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow Viewer - Add the ability to visualise Library contents #3806

Merged
merged 4 commits into from
May 1, 2024

Conversation

joepavitt
Copy link
Contributor

Description

  • Uses the new flow-renderer library to render out a json file if present in the Team Library
  • Also fixes a bug whereby the page rendered no contents in a team library if you refreshed the view when looking at a sin

Related Issue(s)

Closes #3803

Checklist

@joepavitt
Copy link
Contributor Author

Before:

Screenshot 2024-05-01 at 13 07 55

After:

Screenshot 2024-05-01 at 13 07 24

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.14%. Comparing base (2182004) to head (699b080).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3806   +/-   ##
=======================================
  Coverage   79.14%   79.14%           
=======================================
  Files         278      278           
  Lines       12495    12495           
  Branches     2768     2768           
=======================================
  Hits         9889     9889           
  Misses       2606     2606           
Flag Coverage Δ
backend 79.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	frontend/src/pages/team/Library/TeamLibrary.vue
@joepavitt
Copy link
Contributor Author

Have updated to latest main and handled the merge with #3729 which had deleted some files I was editing

@Steve-Mcl
Copy link
Contributor

Approved pending e2e tests

@joepavitt joepavitt merged commit 2c2a7aa into main May 1, 2024
11 checks passed
@joepavitt joepavitt deleted the 3798-flowviewer branch May 1, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flow Viewer: Team Library
2 participants