Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert incorrect flowforge -> flowfuse #4037

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Revert incorrect flowforge -> flowfuse #4037

merged 1 commit into from
Jun 18, 2024

Conversation

hardillb
Copy link
Contributor

Description

This should not have been changed.

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb requested a review from ZJvandeWeg June 17, 2024 16:34
@hardillb hardillb self-assigned this Jun 17, 2024
@ZJvandeWeg
Copy link
Member

@hardillb When is that being changed though? We shouldn't be using flowforge anymore.

ZJvandeWeg
ZJvandeWeg approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@ZJvandeWeg ZJvandeWeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joepavitt Can you make sure the follow up task is created?

@hardillb
Copy link
Contributor Author

@ZJvandeWeg No this will not change as it will break any users custom stack containers.

@hardillb hardillb merged commit 0e3e0b4 into main Jun 18, 2024
9 checks passed
@hardillb hardillb deleted the hardillb-patch-1 branch June 18, 2024 08:29
@joepavitt
Copy link
Contributor

so, even new users are still having to use flowforge?

@hardillb
Copy link
Contributor Author

Yes

@joepavitt
Copy link
Contributor

We aren't called flowforge anymore, so this shouldn't be the case. Why will it break for users with custom stack containers? It's a breaking chage we will need to introduce at some point, otherwise our re-brand isn't fulfilled

@hardillb
Copy link
Contributor Author

That ship has already sailed, the time to do it was when we changed the container names from flowforge/... to flowfuse/...

The only time we could do it now is when we ship v3.0

@joepavitt
Copy link
Contributor

joepavitt commented Jun 18, 2024 •
edited
Loading

okay, which repo is appropriate to ensure we track this? nr-launcher?

@hardillb
Copy link
Contributor Author

FlowFuse/helm & FlowFuse/docker-compose

hardillb added a commit to FlowFuse/helm that referenced this pull request Jul 6, 2024
@hardillb
rebrand working directory
f4ea924 
Workaround for FlowFuse/flowfuse#4037
hardillb added a commit to FlowFuse/docker-compose that referenced this pull request Jul 6, 2024
@hardillb
rebrand working dir
68b3535 
part of fix for FlowFuse/flowfuse#4037
This was referenced Jul 6, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZJvandeWeg ZJvandeWeg ZJvandeWeg approved these changes

@joepavitt joepavitt joepavitt approved these changes

Assignees

@hardillb hardillb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hardillb @ZJvandeWeg @joepavitt