-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component Update: ff-data-table #798
Conversation
Examples of the new data-table in action: Screen.Recording.2022-07-29.at.17.33.28.mov |
Some minor inconsistencies to consider, but otherwise looks good. Checked most views without incident.
Also spotted a couple places where the "+ Add Thing" button is in the header and in some places its inline with the search box. Not necessary for this PR, but would be good to standardise. Will hold off merging pending your thoughts on above. |
You're absolutely spot on, there are a couple of page layout inconsistencies in that regard. If I'm honest, I haven't quite worked out why I like it in some places, and not in others. There are some wider layout designs that I want to improve before committing either way, so I'm happy with what we have for now |
@knolleary pushed the fix for missing search bars |
Closes #794. Reliant upon FlowFuse/forge-ui-components#34 and an
npm publish
offorge-ui-components