Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component Update: ff-data-table #798

Merged
merged 17 commits into from
Aug 2, 2022
Merged

Component Update: ff-data-table #798

merged 17 commits into from
Aug 2, 2022

Conversation

joepavitt
Copy link
Contributor

@joepavitt joepavitt commented Jul 22, 2022

Closes #794. Reliant upon FlowFuse/forge-ui-components#34 and an npm publish of forge-ui-components

@joepavitt joepavitt changed the title ff-data-table update for 'Team > Members' Component Update: ff-data-table Jul 29, 2022
@joepavitt joepavitt marked this pull request as ready for review July 29, 2022 16:29
@joepavitt joepavitt requested a review from knolleary July 29, 2022 16:33
@joepavitt
Copy link
Contributor Author

Examples of the new data-table in action:

Screen.Recording.2022-07-29.at.17.33.28.mov

@knolleary
Copy link
Member

knolleary commented Aug 1, 2022

Some minor inconsistencies to consider, but otherwise looks good. Checked most views without incident.

  • admin/stacks - no search bar on 'inactive stacks' table
  • admin/templates - no search bar
  • admin/users/invitations - no search bar

Also spotted a couple places where the "+ Add Thing" button is in the header and in some places its inline with the search box. Not necessary for this PR, but would be good to standardise.

Will hold off merging pending your thoughts on above.

@joepavitt
Copy link
Contributor Author

Also spotted a couple places where the "+ Add Thing" button is in the header and in some places its inline with the search box. Not necessary for this PR, but would be good to standardise.

You're absolutely spot on, there are a couple of page layout inconsistencies in that regard. If I'm honest, I haven't quite worked out why I like it in some places, and not in others. There are some wider layout designs that I want to improve before committing either way, so I'm happy with what we have for now

@joepavitt
Copy link
Contributor Author

@knolleary pushed the fix for missing search bars

@knolleary knolleary merged commit 1817cf7 into main Aug 2, 2022
@knolleary knolleary deleted the data-table-component branch August 2, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tables to use the new ff-data-table
2 participants