Prevent user with unverified email from accessing API #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user isn't logged in, don't try to load their teams etc
knolleary
force-pushed
the
block-unverified-user
branch
from
f5e05dd
to
6946d6b
Compare
We want to be more intentional over what routes tokens are allowed to access.
|
One minor issue with the UX change here is there is no way for the user to log out. They will forever get this screen until they verify or the session cookie expires. Bit of an edge case, but if you have multiple accounts and are testing the platform, you find yourself stuck and needing to open incognito browser windows. |
Ensure access tokens can only access specific allowed routes
joepavitt
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/flowforge/security/issues/3
This restricts the admin api so users with unverified emails cannot call it.
It is possible to poke holes in the api for specific routes by adding
{ config: { allowUnverifiedEmail: true } }This also reworks the UX for such a user. It is now consistent with the 'expired password' ux - they don't get in to the platform to try doing anything: