Add ability to update T+Cs to cause a re-review / reaccept for users

[Steve-Mcl]

fixes #451

TODO:

• update design on story
• tests

[Steve-Mcl]

@knolleary this is now ready for review.

NOTE: e2e test failing on team membership as your licence limits PR

  FlowForge - Team Membership
    ✓ loads team members into the data table (3777ms)
    ✓ member cannot can invite or remove a user (3108ms)
    ✓ owner/admin can invite user (3578ms)
    ✓ loads invitations into the data table (2318ms)
    1) user can accept a team invite
    2) admin/owner can remove a member from the team


  4 passing (27s)
  2 failing

  1) FlowForge - Team Membership
       user can accept a team invite:
     AssertionError: Timed out retrying after 4000ms: Too many elements found. Found '1', expected '0'.
      at Context.eval (http://localhost:3000/__cypress/tests?p=test/e2e/frontend/cypress/tests/team-membership.spec.js:142:60)

  2) FlowForge - Team Membership
       admin/owner can remove a member from the team:

      AssertionError: Timed out retrying after 4000ms: Not enough elements found. Found '3', expected '4'.
      + expected - actual

      -3
      +4

... this should be fixed when 9921b43 is merged

[knolleary]

We already have a migration in main that has the prefix forge/db/migrations/20220905-01-. It's complete filename comes after the one added by this PR, which will mean this migration will be skipped in any local install that has already run the main code.

Can you rename the migration file to today's date?

[knolleary]

Sorry - I mucked up resolving the merge conflict. Have pushed the fix.

[knolleary]

Generally looks good - but I think some UX changes are needed on the admin settings page.

I have worked up the following. LMK what you think:

Note I have proposed here that changing the T&Cs url should also trigger an update. How does that sound? Or do we want the admin to be able to change the url without triggering re-acceptance?

[Steve-Mcl]

Generally looks good - but I think some UX changes are needed on the admin settings page.

I have worked up the following. LMK what you think:

Note I have proposed here that changing the T&Cs url should also trigger an update. How does that sound? Or do we want the admin to be able to change the url without triggering re-acceptance?

Very much agree - and i did try (and failed) so left it as was

If you have the necessary html to how you achieved the cleaner look - please send it my way (or update the PR)

Either way let me know.

[Steve-Mcl]

We already have a migration in main that has the prefix forge/db/migrations/20220905-01-. It's complete filename comes after the one added by this PR, which will mean this migration will be skipped in any local install that has already run the main code.

Can you rename the migration file to today's date?

What are the odds we both wrote DB migrations on the same date lol

Will push update shortly

[knolleary]

I have pushed the UI changes.

One more piece to add (updating the date when the url is changed)... will update here when done

[knolleary]

I've updated the logic around saving admin settings to ensure tcs-updated gets set at the right times.

There was also an undiscovered bug around detecting if the tcs url has changed in the saveEnabled computed property.

[Steve-Mcl]

Tests updated to ensure presence of/absence of tcs settings in the user API

Added a couple more tests that seem appropriate...

• Terms and Conditions
  • admin can enable Terms and Conditions
  • admin can update Terms and Conditions date
  • user can accept Terms and Conditions
  • user API does not return T&Cs properties if T&Cs are disabled

[Steve-Mcl]

@knolleary - finally passing e2e tests once more.

The modification you pushed that sets the T+Cs date upon URL change caused the e2e tests to get stuck expecting something other than the T+Cs dialog.

Sorted now.