Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure project name starts with alpha char #958

Merged
merged 4 commits into from
Sep 8, 2022

Conversation

Steve-Mcl
Copy link
Contributor

fixes #957

Copy link
Contributor

@hardillb hardillb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight extra in regex

frontend/src/pages/team/createProject.vue Outdated Show resolved Hide resolved
@Steve-Mcl
Copy link
Contributor Author

@hardillb ready for (re)review please

@Steve-Mcl
Copy link
Contributor Author

e2e test fail is odd...

 FlowForge - Team Membership
    ✓ loads team members into the data table (4026ms)
    ✓ member cannot can invite or remove a user (3647ms)
    1) admin/owner can remove a member from the team
    ✓ owner/admin can invite user (3930ms)
    ✓ loads invitations into the data table (3087ms)
    ✓ user can accept a team invite (4924ms)


  5 passing (28s)
  1 failing

  1) FlowForge - Team Membership
       admin/owner can remove a member from the team:
     AssertionError: Timed out retrying after 4000ms: Not enough elements found. Found '0', expected '2'.
      at Context.eval (http://localhost:3000/__cypress/tests?p=test/e2e/frontend/cypress/tests/team-membership.spec.js:133:58)

Gonna merge main -> PR as there have been changes in this area.

@hardillb
Copy link
Contributor

hardillb commented Sep 8, 2022

I didn't merge it as I was just looking at the tests

@Steve-Mcl
Copy link
Contributor Author

I didn't merge it as I was just looking at the tests

I've merged main & ran e2e locally...

image

Lets see how GH fairs after I sync up

@Steve-Mcl
Copy link
Contributor Author

@hardillb yeah - ignore that the test is failing after re-building...

image

Looking into it now.

@Steve-Mcl
Copy link
Contributor Author

re-jigged tests @hardillb

image

Should pass this time 🤞

Please re-review and merge if pass

@hardillb hardillb merged commit a90bd1b into main Sep 8, 2022
@Steve-Mcl Steve-Mcl deleted the project-name-must-start-with-alphachar branch September 8, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Projects should start with an alpha char
2 participants