-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ensure project name starts with alpha char #958
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slight extra in regex
@hardillb ready for (re)review please |
e2e test fail is odd...
Gonna merge main -> PR as there have been changes in this area. |
I didn't merge it as I was just looking at the tests |
@hardillb yeah - ignore that the test is failing after re-building... Looking into it now. |
re-jigged tests @hardillb Should pass this time 🤞 Please re-review and merge if pass |
fixes #957