-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add httpNodeAuth settings #965
Conversation
Does the password bcrypt in page so only the hash is ever sent to the backend and stored in the database |
@knolleary I have pushed what might be a slightly naive fix for the password getting overwitten on any other change to the template. |
Allows the setting of a single username/password in the template
b860449
to
f23a2ee
Compare
I've reworked how passwords are handled in template settings. We now hash them in the backend before they are stored. We never return the value in the api - we return a boolean to indicate if a non-blank value exists. The UI then does the Right Thing to show a placeholder or not. I have verified the settings are applied properly by the launcher - and that the values can be overridden in the project. There is one PR to come against the launcher to avoid righting blank settings into httpNodeAuth. |
Huh - @hardillb as the person who raised this PR originally, it will now let me add you as a reviewer (which is why I tried unassigning it from you first...). Please take a look. |
Yep, was already looking, got confused for a second as to why there was no change to package.json to remove the |
Code looks OK, but 2 of the UI tests are with something to do with httpNodeAuth |
All the tests pass locally, so I'm happy to merge this (and we need to set aside some time next sprint to fix the postgres tests and work out what's happening here) |
Allows the setting of a single username/password in the template
Fixes ##578
Requires FlowFuse/nr-launcher#64