Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add billing to device lifecycle #970

Merged
merged 8 commits into from
Sep 13, 2022
Merged

Add billing to device lifecycle #970

merged 8 commits into from
Sep 13, 2022

Conversation

knolleary
Copy link
Member

Part of #782

This adds a billing step to the device lifecycle.

If billing.stripe.device_product/device_price are set, then whenever a device is added/removed from team, the billing subscription item is updated for the team to reflect how many devices are in the team.

If the team type includes a deviceFreeAllocation property, this is taken into account when identifying how many 'billable' devices a team has.

This PR does not update the UI - that will come in the final PR for this story.

Co-authored-by: Stephen McLaughlin <44235289+Steve-Mcl@users.noreply.github.com>
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1st review pass complete

@knolleary
Copy link
Member Author

I have now added the final test for deviceFreeAllocation.

Prompt user to confirm per-device charge when registering charge
@Steve-Mcl Steve-Mcl merged commit de3ca9c into main Sep 13, 2022
@Steve-Mcl Steve-Mcl deleted the device-billing branch September 13, 2022 16:27
@knolleary knolleary mentioned this pull request Sep 15, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants