Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vue component name for NoVerifiedEmail.vue #977

Merged
merged 2 commits into from Sep 13, 2022
Merged

Update vue component name for NoVerifiedEmail.vue #977

merged 2 commits into from Sep 13, 2022

Conversation

ArshErgon
Copy link
Contributor

#960 updated the name for NoVerifiedEmail

@hardillb
Copy link
Contributor

We don't check lock files into our projects at this time, please remove yarn.lock

@hardillb hardillb changed the title #960 edit Update Vue Component name for NoVerifiedEmail.vue Sep 13, 2022
@hardillb hardillb changed the title Update Vue Component name for NoVerifiedEmail.vue Update vue component name for NoVerifiedEmail.vue Sep 13, 2022
@hardillb
Copy link
Contributor

@ArshErgon Thanks for this

Just a couple of notes

  • we don't put the issue number in the Pull Request title as we use these as part of the change log. There is a guide in the handbook here. I have edited the title to be descriptive.
  • You should include the issue number in the form of closes #.... or fixes #.... I have added a relevant note to this comment.

closes #960

@Steve-Mcl Steve-Mcl linked an issue Sep 13, 2022 that may be closed by this pull request
@hardillb hardillb merged commit 8892c76 into FlowFuse:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong name property in NoVerifiedEmail.vue
2 participants