New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix User Edit dialog wont close & save btn state #984

Merged

hardillb merged 1 commit into main from user-edit-disable-save-if-no-change

Sep 15, 2022

Contributor

Steve-Mcl commented Sep 14, 2022 •

edited

fixes #979

NOTE This should be merged before commencing #983 to avoid merge issues and duplicate works.

What it does...

Ensures save button is not "lit up" if there is a validation error or no changes were detected
Catch all: Closes dialog on "Save" if somehow the Save button is "lit up" but no changes were made / detected


          fix User Edit dialog wont close & save btn state

fixes Save button in admin user-edit dialog doesn't close dialog #979

Steve-Mcl mentioned this pull request

User names can be same (but different case) #983

Closed

Steve-Mcl requested a review from knolleary

September 14, 2022 13:01

hardillb approved these changes

View reviewed changes

hardillb merged commit 8ca0233 into main

hardillb deleted the user-edit-disable-save-if-no-change branch

September 15, 2022 13:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment