Add case-insensitive unique constraint on User.username and email #993
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #983
It took some digging, but I found a sequelize unit test for adding a unique index that uses the
lower
function. This means we can add a unique index to the table, without having to add another column:I have tested and verified this constrain works as required on both sqlite and postgres.
Alongside this, I've updated the
User.byUsername/email
getter functions to do case insensitive queries and improved the feedback in the Admin Create User page and User Registration page.