Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow variable substituion in Ingress Annotations #156

Merged
merged 14 commits into from
Aug 1, 2023
Merged

Allow variable substituion in Ingress Annotations #156

merged 14 commits into from
Aug 1, 2023

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Jul 26, 2023 •
edited
Loading

part of #155

Description

Allow some substitution in ingress annotation values

Related Issue(s)

#155

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb changed the title First pass at substitution Allow variable substituion in Ingress Annotations Jul 26, 2023
@hardillb hardillb mentioned this pull request Jul 31, 2023
Merged
11 tasks
@hardillb hardillb marked this pull request as ready for review July 31, 2023 14:06
@hardillb hardillb requested a review from ppawlowski July 31, 2023 14:06
@hardillb hardillb self-assigned this Jul 31, 2023
@hardillb hardillb added this to the 1.10 milestone Jul 31, 2023
@hardillb
Copy link
Contributor Author

hardillb commented Aug 1, 2023

I cleaned up the PR and also fixed a default that needed to be reverted in the values.yml

@hardillb
Copy link
Contributor Author

hardillb commented Aug 1, 2023

@ppawlowski If you can give this another look please

@hardillb hardillb merged commit eecc041 into main Aug 1, 2023
1 check passed
@hardillb hardillb deleted the forge-annotations branch August 1, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppawlowski ppawlowski ppawlowski approved these changes

Assignees

@hardillb hardillb

Labels
None yet
Projects
None yet
Milestone
1.10
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hardillb @ppawlowski