Add Rate Limit details #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steve-Mcl
reviewed
Aug 1, 2023
Steve-Mcl
reviewed
Aug 1, 2023
Steve-Mcl
reviewed
Aug 1, 2023
helm/flowforge/values.yaml
Outdated
| enabled: false | ||
| global: true | ||
| max: 1000 | ||
| maxAnonymous: 10 |
There was a problem hiding this comment.
Suggested change
| maxAnonymous: 10 |
According to our defaults and docs, this should not be set.
There was a problem hiding this comment.
perhaps it could be undefined if it needs to be present?
There was a problem hiding this comment.
Having it as an example value in the flowforge.yml STRONGLY implies it is the default value. If that is not the case then it needs be updated.
Also it's not clear, is this a fastify-rate-limit value or something you've added?
Steve-Mcl
approved these changes
Aug 1, 2023
|
@hardillb. approved. However I will not merge any of these - I will leave merging for you to coordinate appropriately. |
hardillb
commented
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of FlowFuse/flowfuse#2530
Description
Allow rate limiting to be enabled
Related Issue(s)
FlowFuse/flowfuse#2530
Checklist
flowforge.yml?flowforge/helmto update ConfigMap Templateflowforge/CloudProjectto update values for Staging/ProductionLabels
backportlabelarea:migrationlabel