Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary container image build arguments #178

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Remove unnecessary container image build arguments #178

wants to merge 1 commit into from

Conversation

ppawlowski
Copy link
Contributor

@ppawlowski ppawlowski commented Sep 18, 2023 •
edited
Loading

Description

Follow up for FlowFuse/github-actions-workflows#18

Related Issue(s)

210

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@ppawlowski ppawlowski temporarily deployed to stage September 18, 2023 14:50 — with GitHub Actions Inactive
@ppawlowski ppawlowski temporarily deployed to stage September 18, 2023 14:50 — with GitHub Actions Inactive
@ppawlowski ppawlowski temporarily deployed to stage September 18, 2023 14:50 — with GitHub Actions Inactive
@ppawlowski ppawlowski temporarily deployed to stage September 18, 2023 14:50 — with GitHub Actions Inactive
@ppawlowski ppawlowski temporarily deployed to stage September 18, 2023 14:53 — with GitHub Actions Inactive
@ppawlowski ppawlowski temporarily deployed to stage September 18, 2023 14:55 — with GitHub Actions Inactive
@ppawlowski ppawlowski temporarily deployed to stage September 18, 2023 15:17 — with GitHub Actions Inactive
@ppawlowski ppawlowski temporarily deployed to stage September 18, 2023 15:17 — with GitHub Actions Inactive
@ppawlowski ppawlowski temporarily deployed to stage September 18, 2023 15:17 — with GitHub Actions Inactive
@hardillb
Copy link
Contributor

Can we leave these in place for now please. I use them when building locally for my kube environment

@ppawlowski ppawlowski marked this pull request as draft September 19, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardillb hardillb Awaiting requested review from hardillb

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ppawlowski @hardillb