Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use file-server container for db upgrade job #307

Merged
merged 7 commits into from
Feb 29, 2024

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Feb 12, 2024

fixes #306

Description

While testing installing on OpenShift the db upgrade job fails because it's no longer run as the root user so can't install the psql command into the alpine container image.

This adds the psql command to the file-server image and uses this to run the job.

Related Issue(s)

#306

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb added this to the 2.1 milestone Feb 12, 2024
@hardillb hardillb self-assigned this Feb 12, 2024
@hardillb hardillb changed the title Use file-server container for db upgrade job fix: Use file-server container for db upgrade job Feb 12, 2024
Copy link

github-actions bot commented Feb 12, 2024

node-red:2.2.3-main-linux-amd64 scan results

26 tests    0 ✅  0s ⏱️
 4 suites   0 💤
 1 files    26 ❌

For more details on these failures, see this check.

Results for commit 71218ab.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 12, 2024

node-red:3.0.2-main-linux-amd64 scan results

 1 files  4 suites   0s ⏱️
 9 tests 0 ✅ 0 💤  9 ❌
10 runs  0 ✅ 0 💤 10 ❌

For more details on these failures, see this check.

Results for commit 71218ab.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 12, 2024

node-red:3.1.x-main-linux-amd64 scan results

8 tests   0 ✅  0s ⏱️
4 suites  0 💤
1 files    8 ❌

For more details on these failures, see this check.

Results for commit 71218ab.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 12, 2024

file-server:main-linux-amd64 scan results

1 tests   0 ✅  0s ⏱️
6 suites  0 💤
1 files    1 ❌

For more details on these failures, see this check.

Results for commit 71218ab.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 12, 2024

node-red:3.0.2-main-linux-arm64 scan results

 1 files  4 suites   0s ⏱️
 9 tests 0 ✅ 0 💤  9 ❌
10 runs  0 ✅ 0 💤 10 ❌

For more details on these failures, see this check.

Results for commit 71218ab.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 12, 2024

node-red:2.2.3-main-linux-arm64 scan results

26 tests    0 ✅  0s ⏱️
 4 suites   0 💤
 1 files    26 ❌

For more details on these failures, see this check.

Results for commit 71218ab.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 12, 2024

node-red:3.1.x-main-linux-arm64 scan results

8 tests   0 ✅  0s ⏱️
4 suites  0 💤
1 files    8 ❌

For more details on these failures, see this check.

Results for commit 71218ab.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 12, 2024

file-server:main-linux-arm64 scan results

1 tests   0 ✅  0s ⏱️
6 suites  0 💤
1 files    1 ❌

For more details on these failures, see this check.

Results for commit 71218ab.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 12, 2024

forge-k8s:main-linux-amd64 scan results

1 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
4 suites ±0   0 💤 ±0 
1 files   ±0   1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 71218ab. ± Comparison against base commit b3cd583.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 12, 2024

forge-k8s:main-linux-arm64 scan results

1 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
4 suites ±0   0 💤 ±0 
1 files   ±0   1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 71218ab. ± Comparison against base commit b3cd583.

♻️ This comment has been updated with latest results.

@hardillb
Copy link
Contributor Author

I assume the validation failed because the file-server container wasn't built?

https://github.com/FlowFuse/helm/actions/runs/7870917055/job/21473105621?pr=307#step:10:561

@hardillb
Copy link
Contributor Author

@ppawlowski Just checking, the failed job looks to be using the latest containers from the docker hub, not the ones built as part of the PR test, so the failure is because the new version of the container is not published yet?

file-server/Dockerfile Outdated Show resolved Hide resolved
@hardillb
Copy link
Contributor Author

I'll test this when I get chance locally

Co-authored-by: Ben Hardill <ben@flowforge.com>
@hardillb hardillb merged commit 60d1ba0 into main Feb 29, 2024
16 checks passed
@hardillb hardillb deleted the upgrade-job-container branch February 29, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade job needs it's own container image
2 participants