Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Drop all capabilities for init container #333

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

ppawlowski
Copy link
Contributor

Description

This PR adds a drop of all capabilities for init container. The main reasons of not making this parameter configurable are:

  • init container does single, simple task which does not require capabilities to be modified
  • I am pretty sure that init container is a short term solution of how we are passing configuration parameters to the forge app and will not stay with us for a long time

I have tested such configuration locally and init container does its job as expected.

Related Issue(s)

https://github.com/FlowFuse/CloudProject/issues/320
https://github.com/FlowFuse/CloudProject/issues/319

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb merged commit 983e944 into main Feb 29, 2024
6 checks passed
@hardillb hardillb deleted the feat-init-container-capabilities branch February 29, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants