Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: role binding references #367

Merged
merged 2 commits into from
Apr 29, 2024
Merged

fix: role binding references #367

merged 2 commits into from
Apr 29, 2024

Conversation

ppawlowski
Copy link
Contributor

Description

This pull request fixes a bug introduced in the previous PR.
The problem was that the role binding did not reference the correct service account used by the application pod. As a result, the instance creation process failed due to insufficient permissions to start the pod in a different namespace.

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@ppawlowski ppawlowski merged commit aa0609b into main Apr 29, 2024
6 checks passed
@ppawlowski ppawlowski deleted the fix-sa-namespace branch April 29, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants