Use GH token to auth if using custom repo #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knolleary
reviewed
Sep 13, 2022
flowforge-container/Dockerfile
Outdated
| ARG TAG | ||
| RUN if [[ ! -z "$REGISTRY_TOKEN" ]]; then echo "//npm.pkg.github.com/:_authtoken=$REGISTRY_TOKEN" >> ~/.npmrc ; fi |
There was a problem hiding this comment.
should the npm.pkg.github.com bit be picked up from $REGISTRY or am I misunderstanding what these bits are doing?
There was a problem hiding this comment.
The problem is that npm wants a full URL for the registry (e.g. https://npm.pkg.github.com/) and only a URL fragment (no schema e.g. //npm.pkg.github.com/ ) for the authentication token key.
I suppose I could just pass the fragment in from the GH Action and then pre-pend the schema in the next line to make it all parametrised.
Also allow passing in a npm build tag to the nr-launcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the work needed to move to GH npm repo for nightly builds