Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme option overlays dashboard components #706

Closed
ThomasAndreini opened this issue Mar 24, 2024 · 8 comments · Fixed by #744
Closed

Theme option overlays dashboard components #706

ThomasAndreini opened this issue Mar 24, 2024 · 8 comments · Fixed by #744
Assignees
Labels
bug Something isn't working size:S - 2 Sizing estimation point

Comments

@ThomasAndreini
Copy link

Current Behavior

when enough pages and groups are generated, some will fall behind the theme component

Expected Behavior

theme component does not overlap

Steps To Reproduce

create almost 13 element like page or group

Environment

  • Dashboard version: 1.5.1
  • Node-RED version: 3.1.5
  • Node.js version: 18
  • npm version:
  • Platform/OS: docker
  • Browser: Chrome
    Screenshot 2024-03-24 13 44 58

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

@ThomasAndreini ThomasAndreini added bug Something isn't working needs-triage Needs looking at to decide what to do labels Mar 24, 2024
@colinl
Copy link
Contributor

colinl commented Mar 24, 2024

Clicking the Theming tab and returning to the Layout tab cures the problem temporarily.

@joepavitt
Copy link
Collaborator

Thanks for raising this, I've seen it in so many tutorials and videos online, but I've never been able to reproduce this locally - it's very annoying.

I'll add it to the list, and see if I can understand, without being able to reproduce, why it might be occuring.

@joepavitt joepavitt added size:S - 2 Sizing estimation point and removed needs-triage Needs looking at to decide what to do labels Mar 26, 2024
@colinl
Copy link
Contributor

colinl commented Mar 26, 2024

Have you tried it with an example with several pages and lots of widgets?

@joepavitt
Copy link
Collaborator

Have you tried it with an example with several pages and lots of widgets?

My local test instance has 14 pages and about 140 widgets 😄

@colinl
Copy link
Contributor

colinl commented Mar 26, 2024

I will have a look later and see if I can find a pattern

@colinl
Copy link
Contributor

colinl commented Mar 26, 2024

I am seeing it in Chrome and Firefox running on Ubuntu. Nothing in the browser console.
NR 3.1.5, dashboard 1.4.1 running in a Pi and NR 4.0.0 Beta 1 with dashboard 1.5.1 both show the problem.
Not using Docker.

@ThomasAndreini
Copy link
Author

ThomasAndreini commented Mar 30, 2024

I add that I am using node red via docker, also using the colinl trick the overlap disappears but if I select another tab, for example debug or context and go back to the dashboard tab the overlap return.
I don't think it's relevant but the only change made to the config file was to enable persistence for contexts

@m-schaeffler
Copy link
Contributor

I have seen this on this setup:
dashboard: 1.6.1
nodered: 4.0.0 beta1
browser: firefox@ubuntu and firefox@win10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:S - 2 Sizing estimation point
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants