Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile with full Vue build to allow for runtime compiling of ui-template #350

Merged
merged 1 commit into from Nov 16, 2023

Conversation

joepavitt
Copy link
Collaborator

Description

Noticed in #340 - when testing the ui-template after we switched main to use a vite build, the templates were entirely broken with no errors reported.

This boiled down to https://vuejs.org/api/options-rendering.html#template:~:text=It%20is%20only%20supported%20when%20using%20a%20build%20of%20Vue%20that%20includes%20the%20template%20compiler.

Fixed by aliasing the vue build to be the full build of Vue, not just the runtime.

Checklist

@joepavitt joepavitt requested a review from Pezmc November 16, 2023 09:27
@Pezmc Pezmc merged commit 1192e23 into main Nov 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants