Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate source map during development #834

Merged
merged 4 commits into from
May 9, 2024

Conversation

bartbutenaers
Copy link
Contributor

Description

During the Vite build phase, the frontend code is being minified. Which made it quite hard for me to contribute to this repo. This pull request uses the same mechanism as in the node-red-dashboard-2-ui-example repo to allow skipping minification during the development phase.

I have also added an extra (optional) step to the documentation, but imho the developing locally section should be not under third-party widgets, because it is also required when you want to contribute to the dashboard...

Related Issue(s)

See 819

Checklist

  • [ X ] I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@bartbutenaers bartbutenaers changed the title Skip minification during development Generate source map during development May 9, 2024
@joepavitt
Copy link
Collaborator

joepavitt commented May 9, 2024

There is a difference in the instructions detailed in the Contributing Guide and the Third Party Widgets - developing locally section in that the latter installs node-red-dashboard via manage palette, the former installs the source code base for modifications directly to Dashboard itself.

So, the vite change you've made will effect core Dashboard, but the docs you updated refer to the UIExample repository. My understanding is that the UI Example repo does still offer this functionality, so they're valid updates, but we also need to update the base Contributing install instructions too please!

@bartbutenaers
Copy link
Contributor Author

Based on this discussion on Discourse, I have updated the title and modifications in this PR.

@joepavitt joepavitt merged commit 5d3875f into FlowFuse:main May 9, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants