Log passthrough #207
Merged
Log passthrough #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
Steve-Mcl
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
I understand from reading the issue this is an MVP (i.e. we are NOT outputting "Elastic Common Schema (ECS) format" as requested by the OP) so I fully agree with the approach of using an ENV VAR (permitting the user who requires this can simply add FORGE_LOG_PASSTHROUGH ) as a good MVP.
However, will there be an update to the docs to accompany this? Or is it intentionally a "behind the scenes" feature Ben?
|
The doc updates are included in the driver update PRs that allow you to enable this. |
Perfect - thanks for letting me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of FlowFuse/flowfuse#3324
Description
Allow nr-launcher to print Node-RED logs (in JSON format) to stdout. This allows it to be ingested by log services on docker/k8s
Related Issue(s)
FlowFuse/flowfuse#3324
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
backportlabelarea:migrationlabel