Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Http node auth token #212

Merged
merged 6 commits into from
Mar 11, 2024
Merged

Http node auth token #212

merged 6 commits into from
Mar 11, 2024

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Mar 1, 2024 •
edited

part of FlowFuse/flowfuse#2964

Description

Add support for HTTP Bearer tokens for HTTP-in/HTTP-out endpoints when FF auth enabled.

Depends on FlowFuse/flowfuse#3535

Related Issue(s)

FlowFuse/flowfuse#2964

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb added this to the 2.2 milestone Mar 1, 2024
@hardillb hardillb self-assigned this Mar 1, 2024
@hardillb hardillb mentioned this pull request Mar 1, 2024
Merged
11 tasks
@hardillb hardillb requested a review from Steve-Mcl March 5, 2024 14:02
@hardillb hardillb marked this pull request as ready for review March 5, 2024 14:02
@hardillb
Copy link
Contributor Author

hardillb commented Mar 5, 2024

@Steve-Mcl be aware this needs the matching Forge app PR to test against

Steve-Mcl
Steve-Mcl reviewed Mar 11, 2024
View reviewed changes
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very minor niggles Ben. Otherwise, tested and working locally against the related FF core branch.

lib/auth/httpAuthMiddleware.js Outdated Show resolved Hide resolved
lib/auth/httpAuthMiddleware.js Outdated Show resolved Hide resolved
lib/auth/httpAuthMiddleware.js Outdated Show resolved Hide resolved
lib/auth/httpAuthMiddleware.js Outdated Show resolved Hide resolved
hardillb and others added 2 commits March 11, 2024 14:06
@hardillb @Steve-Mcl
Apply suggestions from code review
34f0e59 
Co-authored-by: Stephen McLaughlin <44235289+Steve-Mcl@users.noreply.github.com>
@hardillb
Fix comment
eaa5570
@hardillb hardillb requested a review from Steve-Mcl March 11, 2024 14:07
@Steve-Mcl Steve-Mcl merged commit d51c68c into main Mar 11, 2024
5 checks passed
@Steve-Mcl Steve-Mcl deleted the httpNodeAuth-token branch March 11, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steve-Mcl Steve-Mcl Steve-Mcl approved these changes

Assignees

@hardillb hardillb

Labels
None yet
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hardillb @Steve-Mcl