-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the parent window to configure and manage navigation requests #224
Allow the parent window to configure and manage navigation requests #224
Conversation
…hen the NR editor resides in an embedded context/iframe
Some feedback / input would be appreciated on the interception of the logo click event |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the inner package for the theme plugin should be bumped
@hardillb do you see any technical reason not to bump theme in the inner package.json in this PR?
If we are confident that this is it for changes to the theme, then yes, bump the inner @sherbastian The top level nr-launcher |
Reverted the v bump, the PR should be good to go. It can be released independently of #3656 without any side effects |
…tion-between-iframe-and-parent-window
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good @sherbastian except I beleive we should be updating the internal theme package.json to 1.9.0
@Steve-Mcl, should I do it manually? |
Yes, just update the value in this PR. The inner package is not published and has no automations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled and tested locally against current FF core. Working as expected. Happy to approve.
I won't merge as I don't know the status of the other parts of this puzzle (so just in case any tweaks are needed across the PRs). I'll leave it to you to merge
You can merge at will.
Allow the parent window to configure and manage navigation requests when the NR editor resides in an embedded context/iframe
Description
Related Issue(s)
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
backport
labelarea:migration
label@closes #223