Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User defined health check interval #228

Merged
merged 5 commits into from
May 1, 2024
Merged

Conversation

Steve-Mcl
Copy link
Contributor

@Steve-Mcl Steve-Mcl commented Apr 12, 2024

Description

allow health poll interval to be set via user setting

NOTES:

Adds tests:

  Launcher
    ✔ should create a new launcher
    health check
      ✔ has a default value
      ✔ can be set by user
      ✔ cannot be less than 1 second

Related Issue(s)

#227

TODO

  • tests

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl changed the title 227 health check interval User defined health check interval Apr 12, 2024
@Steve-Mcl Steve-Mcl linked an issue Apr 12, 2024 that may be closed by this pull request
@Steve-Mcl Steve-Mcl marked this pull request as ready for review April 15, 2024 11:38
@knolleary
Copy link
Member

We can merge this PR - but the individual driver PRs can be rejected as we don't need to spread the logic out to them all - see FlowFuse/flowfuse#3578 (comment)

@knolleary knolleary merged commit 64d2704 into main May 1, 2024
5 checks passed
@knolleary knolleary deleted the 227-health-check-interval branch May 1, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Instance Health Check interval to be configured
2 participants