Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Eleventy 2 #458

Merged
merged 4 commits into from
Feb 27, 2023
Merged

Upgrade to Eleventy 2 #458

merged 4 commits into from
Feb 27, 2023

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Feb 24, 2023 •
edited

Description

Why:

Related Issue(s)

#401

Checklist

  • I have read the contribution guidelines
  • I have considered the performance impact of these changes
  • [-] Suitable unit/system level tests have been added and they pass
  • [-] Documentation has been updated

@Pezmc Pezmc mentioned this pull request Feb 24, 2023
Merged
2 tasks
ZJvandeWeg
ZJvandeWeg approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@ZJvandeWeg ZJvandeWeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I can review given I've done the upgrade to v1.0, looks good to me.

Like the src/public changes, that makes some things easier. :)

@Pezmc Pezmc merged commit a62c515 into main Feb 27, 2023
@Pezmc Pezmc deleted the chore-eleventy-2 branch February 27, 2023 16:36
@joepavitt
Copy link
Contributor

joepavitt commented Mar 1, 2023 •
edited by Pezmc

Content moved from /content as its a protected term in Eleventy, and causes issues in Eleventy 2.0, see: 04a9341

@joepavitt
Copy link
Contributor

all reserved terms in Eleventy: 11ty/eleventy#2824

Pezmc added a commit that referenced this pull request Mar 2, 2023
@Pezmc
Revert "Merge pull request #458 from flowforge/chore-eleventy-2"
f776810 
This reverts commit a62c515, reversing
changes made to ea269bd.
Pezmc added a commit that referenced this pull request Mar 2, 2023
@Pezmc
Revert "Revert "Merge pull request #458 from flowforge/chore-eleventy…
08fd5f1 
…-2""

This reverts commit f776810.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZJvandeWeg ZJvandeWeg ZJvandeWeg approved these changes

@knolleary knolleary Awaiting requested review from knolleary

@joepavitt joepavitt Awaiting requested review from joepavitt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pezmc @joepavitt @ZJvandeWeg