fix issue #51 #58
Merged
fix issue #51 #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dominik42
commented
Jun 17, 2023
dominik42
commented
- compile with Vaadin 24.1.0
- using ColumnPathRenderer explicitely
- extend exception log with key for column with missing value
|
The code format settings are still modified by my IDE, despite my 2 additional commits. I assume, this was done during the commit phase, so sorry for that. I do not want to alter your file/code format settings. |
|
Thanks for your contribution. We will merge it to a new major version of the add-on, targeting Vaadin 24 (The current version attempts to be compatible with "23.1+" and it's quite difficult to implement such low level hacks while supporting a broad range of framework versions). |
|
Thanks again! The fix has been released in version 2.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.