Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid code duplication #25

Closed
javier-godoy opened this issue Sep 23, 2020 · 0 comments · Fixed by #27
Closed

Avoid code duplication #25

javier-godoy opened this issue Sep 23, 2020 · 0 comments · Fixed by #27
Assignees
@javier-godoy
Labels
enhancement
Projects
Flowing Code Addons (legacy)
Milestone
2.1.0

Comments

@javier-godoy
Copy link
Member

Several features require applying similar configuration to both the left grid and the right grid. However, in some cases it's hard to reuse the code in its current form, since all the relevant private attributes come in left/right pairs.
@javier-godoy javier-godoy self-assigned this Sep 23, 2020
@javier-godoy javier-godoy added this to Inbox (needs triage) in Flowing Code Addons (legacy) via automation Sep 23, 2020
javier-godoy added a commit that referenced this issue Sep 24, 2020
@javier-godoy
Avoid code duplication (#25)
159d53a
@javier-godoy javier-godoy mentioned this issue Sep 24, 2020
Merged
javier-godoy added a commit that referenced this issue Sep 24, 2020
@javier-godoy
Avoid code duplication (#25)
1169952
Flowing Code Addons (legacy) automation moved this from Inbox (needs triage) to Done Sep 24, 2020
ngonzalezpazFC pushed a commit that referenced this issue Sep 24, 2020
@javier-godoy @ngonzalezpazFC
Avoid code duplication (#25)
5a92faf
@javier-godoy javier-godoy added this to the 2.1.0 milestone Sep 25, 2020
@javier-godoy javier-godoy mentioned this issue Sep 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javier-godoy javier-godoy

Labels
enhancement
Projects
Flowing Code Addons
Status: Done
Flowing Code Addons (legacy)
  
Done
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

Avoid code duplication (#25) FlowingCode/TwinColGridAddon
1 participant
@javier-godoy