Feature/Env Variables #1422
Merged
Feature/Env Variables #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HenryHengZJ
commented
Dec 21, 2023
HenryHengZJ
commented
- Allow user to add variables to be used in custom tool function
- Allow sessionid, chatid to be used in custom tool function
…tool and addition of ($flow) object
vinodkiran
reviewed
Dec 26, 2023
| resumeMessages?(messages: IMessage[]): Promise<void> | ||
| } | ||
|
|
||
| export abstract class FlowiseMemory extends BufferMemory implements MemoryMethods { |
There was a problem hiding this comment.
Why do we need these abstract method declarations in the body? Since the class is abstract the implementation would anyway have to implement all the interface methods!
There was a problem hiding this comment.
We can remove all these and retain the MemoryMethods, then implement this method for every other memory nodes. However the reason I make it into a base class is because I wanted to use this class in OpenAIFunctionAgent so we can have some inferences:
packages/components/nodes/memory/MotorheadMemory/MotorheadMemory.ts
Outdated
Show resolved
Hide resolved
vinodkiran
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.