Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: relative links method and limit not applying to manage links #1687

Merged
merged 5 commits into from
Feb 12, 2024

Conversation

0xi4o
Copy link
Contributor

@0xi4o 0xi4o commented Feb 6, 2024

  • Fixes relativeLinksMethod and limit values set in Additional Parameters in Cheerio, Playwright, and Puppeteer nodes.

@0xi4o 0xi4o changed the title Fixes the issue with relative links method and limit not applying to manage links Fix: relative links method and limit not applying to manage links Feb 6, 2024
@chungyau97
Copy link
Contributor

The error that I found was in Cheerio.ts Line 146.

Steps to reproduce error:

  1. Set Relative Links Method webCrawl and Relative Links Limit to 10
  2. Fetch Links through Manage Links and Click Save
  3. Set Relative Links Method null and Relative Links Limit to 2
  4. Save ChatFlow and Click Upsert
  5. It will return 10 links instead of 2

Change to loop this selectedLinks.slice(0, limit) instead of the whole selectedLinks

@0xi4o
Copy link
Contributor Author

0xi4o commented Feb 6, 2024

@chungyau97 Updated 👍

packages/server/src/index.ts Show resolved Hide resolved
packages/server/src/index.ts Show resolved Hide resolved
@0xi4o 0xi4o merged commit 4e8bf49 into FlowiseAI:main Feb 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants