DynamoDB Chat Memory fix #1697
Merged
DynamoDB Chat Memory fix #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes FlowiseAI#1624 Please note comment in class BufferMemoryExtended for further discussion, if necessary
|
@HenryHengZJ This should fix #1624 I put a comment in packages/components/nodes/memory/DynamoDb/DynamoDb.ts on line 156 for further clarity. It might just be me not understanding the init flow of the BufferMemoryExtended class distinct from the init of the DynamoDb_Memory node. Any clarity around fields.chatHistory and fields.dynamodbClient is appreciated if you have time. I have tested this against an existing flow I have with DynamoDB memory, and it's working as expected. Sessions are being maintained, and overriding the sessionId is working as expected. 
|
HenryHengZJ
reviewed
Feb 8, 2024
HenryHengZJ
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1624
Please note comment in class BufferMemoryExtended for further discussion, if necessary