Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use URL constructor to handle all types of links #1740

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

ape-nq
Copy link
Contributor

@ape-nq ape-nq commented Feb 16, 2024

This should enable to handle all types of relative URLs defined in RFC: https://www.rfc-editor.org/rfc/rfc3986#section-5.4

This should enable to handle all types of relative URLs defined in RFC: https://www.rfc-editor.org/rfc/rfc3986#section-5.4
@HenryHengZJ
Copy link
Contributor

hmm can you give example where the particular link cant be scraped?

@ape-nq
Copy link
Contributor Author

ape-nq commented Feb 20, 2024

Example is in the issue.

I added screenshots for Release and patched version:
#1741 (comment)

@ape-nq
Copy link
Contributor Author

ape-nq commented Feb 20, 2024

I also added a Chatflow to reproduce the example:

@HenryHengZJ
Copy link
Contributor

@chungyau97 can you take a look at this?

@chungyau97
Copy link
Contributor

Hi @ape-nq, thanks for the PR.

I wasn't aware that URL() will handle href and baseurl itself.
https://developer.mozilla.org/en-US/docs/Web/API/URL/URL#examples

@chungyau97
Copy link
Contributor

Hi @ape-nq, you need to update your repo main branch and merge it into this branch to resolve run fail.

@chungyau97 chungyau97 merged commit 714f82a into FlowiseAI:main Feb 27, 2024
2 checks passed
@ape-nq
Copy link
Contributor Author

ape-nq commented Feb 27, 2024

You're welcome!

Thank you and the other Flowise contributors! It really helped me to get started with RAG chatflows. Glad I could help by sending my fix upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants