Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zep cloud setup #1760

Merged
merged 6 commits into from
Feb 26, 2024
Merged

Zep cloud setup #1760

merged 6 commits into from
Feb 26, 2024

Conversation

paul-paliychuk
Copy link
Contributor

No description provided.

@@ -22,6 +22,7 @@
"@datastax/astra-db-ts": "^0.1.2",
"@dqbd/tiktoken": "^1.0.7",
"@elastic/elasticsearch": "^8.9.0",
"@getzep/zep-cloud": "npm:@getzep/zep-js@next",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: We are aliasing a different version of our ts sdk (tagged with next) as we currently only have support for Zep Cloud API in Release Candidate of our ts sdk

@@ -0,0 +1,181 @@
import { IMessage, INode, INodeData, INodeParams, MemoryMethods, MessageType } from '../../../src/Interface'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of creating a new node, what do u think if we just add a new options field to the ZepMemory that allow users to select OpenSource or Cloud, then according to selection, use the respective library for init

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be doable, but I have some reservations.

Our interfaces are not the same for open source and cloud sdk. For memory, for example, we don't offer the ability to specify memoryType on Open Source version, whereas this is one of the new things we have introduced with Zep Cloud. The same applies to vector stores, in cloud fro example we don't accept embeddings and embedding dimensions any more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we would have to have a lot of additional if blocks in the nodes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh okay i thought the difference is only the initialization. In that case, make sense to have separate nodes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Marked it as ready for review then!

@paul-paliychuk paul-paliychuk marked this pull request as ready for review February 20, 2024 17:20
@HenryHengZJ
Copy link
Contributor

@paul-paliychuk some linting issues if you can do yarn lint-fix

@paul-paliychuk
Copy link
Contributor Author

@HenryHengZJ My bad, just ran the linter-fixer


constructor() {
this.label = 'Zep Collection - Cloud'
this.name = 'Zep Collection - Cloud'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the name must be in camelcase zepCloud, otherwise the upsert button will not be shown:
image

Copy link
Contributor

@HenryHengZJ HenryHengZJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @paul-paliychuk !

@HenryHengZJ HenryHengZJ merged commit 89307b1 into FlowiseAI:main Feb 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants