Fix duplicated calculation of nodes and dependent nodes are not initialized #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mokeyish the code make sense to avoid re-calculation of node once it has been initialized. However I'd like to double confirm if I can replicate this issue with a chatflow. So far from my testing, I've not come across with a chatflow that has this issue. Do you have an example chatflow JSON template? |
|
My chatflow is more complicated, but I can take a screenshot. 
|
|
wow thats quite a complex one! from your chatflow, which nodes were re-calculated? |
HenryHengZJ
reviewed
Mar 11, 2024
HenryHengZJ
reviewed
Mar 11, 2024
|
The node that did the initialization repeated the calculation. In fact, it went to the database to read the entire configuration, and subsequent nodes will use the configuration it read. Without this PR, it would read many times and be very slow. |
HenryHengZJ
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same flow graph as #1832