Feature/externalize files from chatflow - do not save as base64 #1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if you do a search |
Yes, working on the rest of the item. Draft PR to ensure that the loaders work as expected with this change. |
|
All nodes with |
# Conflicts: # packages/server/src/index.ts
HenryHengZJ
approved these changes
Apr 3, 2024
jeffh86
added a commit
to jeffh86/Flowise
that referenced
this pull request
Apr 7, 2024
Feature/externalize files from chatflow - do not save as base64 (FlowiseAI#1976)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Flowise saves all uploaded docs as base64 string to the chatflow. It is not scalable with large documents. Issue - #1247
Solution: save the files to a local path and only save the filepath to the chatflow.
This PR extracts the base64 string and saves it to the path specified in env.BLOB_STORAGE_PATH (creates a sub-folder with the chatflowid)
This is backwards compatible, when a current chatflow (with base64 in flowData) is opened and saved, the files are extracted and saved.