Update unstructured document loaders #2213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenryHengZJ
reviewed
Apr 19, 2024
packages/components/nodes/documentloaders/Unstructured/UnstructuredFile.ts
Outdated
Show resolved
Hide resolved
|
Thanks @QuinnGT this is so good! There's a few other parameters we can add in future:
|
|
Thank you! I completely agree. Looking forward to the langchain upgrade so we can bring those additional params in. |
merged! |
HenryHengZJ
approved these changes
Apr 20, 2024
There was a problem hiding this comment.
looks good! are you still planning to add more changes or is it good to merge @QuinnGT ?
|
Busy today but plan on adding the rest of those params tonight (utc-7).
…On Sat, Apr 20, 2024 at 1:25 PM Henry Heng ***@***.***> wrote:
***@***.**** approved this pull request.
looks good! are you still planning to add more changes or is it good to
merge @QuinnGT <https://github.com/QuinnGT> ?
—
Reply to this email directly, view it on GitHub
<#2213 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKSH3R3P3IRXI5QRKAN2IT3Y6LFKNAVCNFSM6AAAAABGOPYZIWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMJTGE2DIMJWHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
…alues, and support for null on multiOptions.
|
Hey @HenryHengZJ take a look at the latest changes. Just tested on multiple docs, fixed some errors, and got it stable. |
awesome thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
ocrLanguagesbut should be updated to be justlanguagesonce langchain unstructured gets an updateNote:
Unstructured folder loader currently doesn't work with different file types like .png and .heic due to problems with their API. This is in progress for future releases.
Also, I would like to add S3Folder loader but I'll do that in a separate PR since langchainjs doesn't support it yet and I'll have to go direct to the sdk.
Issues this addresses: