Add batchSize parameter to Qdrant_VectorStores and QdrantUpsert_Vecto… #2215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenryHengZJ
reviewed
Apr 19, 2024
| @@ -257,7 +265,10 @@ class Qdrant_VectorStores implements INode { | |||
|
|
|||
| return res | |||
| } else { | |||
| await QdrantVectorStore.fromDocuments(finalDocs, embeddings, dbConfig) | |||
| for(let i=0; i<finalDocs.length; i+=batchSize) { | |||
There was a problem hiding this comment.
if no batchSize is found, can we just do it without for loop?
I tried upserting 1k+ chunks, it works fine:
Instead of doing this 10 times in for loop, I think its better for other to specify the batch size once they faced the error, if everything works fine for the first try, then thats great
HenryHengZJ
reviewed
Apr 19, 2024
| name: 'batchSize', | ||
| type: 'number', | ||
| default: 100, | ||
| additionalParams: true |
There was a problem hiding this comment.
can we have an optional: true
|
This is a very important fix.. |
… and QdrantUpsert_VectorStores also try calling normal mode if it fail failback to batch mode
|
In my last commit the batchSize is not required, and I try to POST all at once first and if it fail I fall back to batch mode |
…Upsert_VectorStores
HenryHengZJ
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve the bug related to #2191 and #1824 :
Error: 400 Bad Request: Payload error: JSON payload (xxxxxx bytes) is larger than allowed (limit: 33554432 bytes)