Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Mobile Responsiveness and Close Button to Chat Window #183

Merged
merged 8 commits into from
Jun 12, 2024

Conversation

amansoni7477030
Copy link
Contributor

  1. Added Mobile Responsiveness.
  2. Slightly changed the position of the clear button.
  3. Added Close Button to Chat Window at the top, following the clear button.
  4. When clicking on the chatbot icon in mobile, the chat window now appears in full screen, and the chatbot icon disappears.
  5. Removed auto-focus in the chat window input on mobile devices. This change improves the user experience as it prevents the mobile keyboard from obscuring the window, requiring users to repeatedly press "back" to read.
  6. Improved responsiveness across all platforms, including Android, iOS, PC, tablet, ensuring consistent performance without any issues.

@toi500
Copy link

toi500 commented Jun 5, 2024

Wow, this is outstanding, a really fine piece of work here. I can't wait to see this working.

Just to put @HenryHengZJ in context about the auto-focus issue #132 (comment)

@@ -34,7 +34,7 @@ export const DeleteButton = (props: SendButtonProps) => {
disabled={props.isDisabled || props.isLoading}
{...props}
class={
'py-2 px-4 justify-center font-semibold text-white focus:outline-none flex items-center disabled:opacity-50 disabled:cursor-not-allowed disabled:brightness-100 transition-all filter hover:brightness-90 active:brightness-75 chatbot-button ' +
'py-2 px-12 justify-center font-semibold text-white focus:outline-none flex items-center disabled:opacity-50 disabled:cursor-not-allowed disabled:brightness-100 transition-all filter hover:brightness-90 active:brightness-75 chatbot-button ' +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when using full page chatbot, need to change to px-4, otherwise we see a big space:
image

Copy link
Contributor

@HenryHengZJ HenryHengZJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to px-4 when using full page chatbot

@toi500
Copy link

toi500 commented Jun 12, 2024

@HenryHengZJ is the new autoFocus option/feature only applicable for non-mobile device, right? Leaving the autoFocus on mobiles OFF by default, correct?

I am asking because I've been researching this for months now, and I can assure you that major players don't use autofocus on mobile apps at all. Chatbot.com is a good example:

Same APP:

autoFocus on desktop:

Recording.2024-06-12.145358.mp4

No autoFocus on Mobile:

Record_2024-06-12-14-30-30.mp4

In other words:
-if you use 2 input devices like a mouse and keyboard, autofocus is the way to go for chatbots, since if not, you need manually click in the imput field.
-If you only use 1 input device (like your hand), autofocus isn't needed and can actually be inconvenient, as @amansoni7477030 pointed out, by obscuring the content of the window.

@amansoni7477030
Copy link
Contributor Author

Change to px-4 when using full page chatbot

@HenryHengZJ I have made the requested changes. Please review the updates.

@HenryHengZJ
Copy link
Contributor

Added changes to automatically disable focus when its in mobile mode

@HenryHengZJ HenryHengZJ merged commit dbcbe66 into FlowiseAI:main Jun 12, 2024
@toi500
Copy link

toi500 commented Jun 12, 2024

@amansoni7477030 @HenryHengZJ i really would like to thank you both for your work here.

I think we have now an amazing embedding chatbot app.

Thank you so much 🙌🏼

@amansoni7477030
Copy link
Contributor Author

@toi500 You're welcome ! ithink there is new issue arrived now chatbot icon is not visible becuase of @HenryHengZJ new commit update logic to detect mobile screen
Screenshot from 2024-06-12 19-39-36

can you also verify from your side @HenryHengZJ @toi500

@toi500
Copy link

toi500 commented Jun 12, 2024

@amansoni7477030 same

image

@amansoni7477030
Copy link
Contributor Author

Hii @HenryHengZJ @toi500 Chatbot icon is not visible issue has been fixed now check my latest PR #190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants