New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scope checking should be sets, not lists #6582

Open

Thingus opened this issue May 9, 2024 · 0 comments

Contributor

Thingus commented May 9, 2024 •

edited

From #6581 (comment)

It's compared to other lists when we check it against the requested scopes; now I say that, a set would be better there too, but that probably belongs in a different PR

Given that there's no reason we need duplicate scopes, it's probably sensible to be passing scopes/permissions around as sets instead of lists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment